Skip to content

gh-145492: fix regression test for defaultdict factory repr#145788

Merged
encukou merged 1 commit intopython:mainfrom
KowalskiThomas:kowalski/test-fix-regression-test-for-defaultdict-factory-repr
Mar 11, 2026
Merged

gh-145492: fix regression test for defaultdict factory repr#145788
encukou merged 1 commit intopython:mainfrom
KowalskiThomas:kowalski/test-fix-regression-test-for-defaultdict-factory-repr

Conversation

@KowalskiThomas
Copy link
Contributor

@KowalskiThomas KowalskiThomas commented Mar 10, 2026 •
edited by encukou
Loading

What is this PR?

This PR fixes the regression test introduced in #145761 and that did not properly reproduce the issue.

Running the test without the repr changes now properly crashes.

% ./python.exe -m unittest test.test_defaultdict
..........E..
======================================================================
ERROR: test_repr_recursive_factory (test.test_defaultdict.TestDefaultDict.test_repr_recursive_factory)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/thomas.kowalski/Documents/cpython/Lib/test/test_defaultdict.py", line 219, in test_repr_recursive_factory
    r = repr(dd)
  File "/Users/thomas.kowalski/Documents/cpython/Lib/test/test_defaultdict.py", line 215, in __repr__
    return f"ProblematicFactory for {dd}"
                                    ^^^^
  File "/Users/thomas.kowalski/Documents/cpython/Lib/test/test_defaultdict.py", line 215, in __repr__
    return f"ProblematicFactory for {dd}"
                                    ^^^^
  File "/Users/thomas.kowalski/Documents/cpython/Lib/test/test_defaultdict.py", line 215, in __repr__
    return f"ProblematicFactory for {dd}"
                                    ^^^^
  [Previous line repeated 981 more times]
RecursionError: maximum recursion depth exceeded

----------------------------------------------------------------------
Ran 13 tests in 1.742s

gh-145492

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Mar 10, 2026
@bedevere-app bedevere-app bot mentioned this pull request Mar 10, 2026
Closed
@KowalskiThomas KowalskiThomas mentioned this pull request Mar 10, 2026
Merged
@StanFromIreland StanFromIreland mentioned this pull request Mar 10, 2026
Closed
@YvesDup
Copy link
Contributor

YvesDup commented Mar 11, 2026

This fix looks good to me ;)

@encukou encukou merged commit aa4240e into python:main Mar 11, 2026
51 checks passed
@encukou
Copy link
Member

encukou commented Mar 11, 2026

Thank you!

encukou pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2026
@KowalskiThomas @encukou
pythongh-145492: fix regression test for defaultdict factory repr (py…
1f64798 
…thonGH-145788)
encukou pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2026
@KowalskiThomas @encukou
pythongh-145492: fix regression test for defaultdict factory repr (py…
f5c4f09 
…thonGH-145788)
@KowalskiThomas
Copy link
Contributor Author

KowalskiThomas commented Mar 11, 2026

I guess we should backport the non-regression test as well?

encukou pushed a commit that referenced this pull request Mar 12, 2026
@miss-islington @KowalskiThomas @mvanhorn
[3.14] gh-145492: Fix defaultdict __repr__ infinite recursion (GH-145659
59be951 
) (GH-145747)

(cherry picked from commit 2d35f9b)

Includes test fix-up from GH-145788
(cherry picked from commit aa4240e)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Mar 12, 2026
@miss-islington @KowalskiThomas @mvanhorn
[3.13] gh-145492: Fix defaultdict __repr__ infinite recursion (GH-145659
cef423c 
) (GH-145746)

(cherry picked from commit 2d35f9b)

Includes test fix-up from GH-145788
(cherry picked from commit aa4240e)

Co-authored-by: Thomas Kowalski <thom.kowa@gmail.com>
Co-authored-by: Matt Van Horn <mvanhorn@users.noreply.github.com>
@encukou
Copy link
Member

encukou commented Mar 12, 2026

Yes, I included it in the backports :)

@KowalskiThomas
Copy link
Contributor Author

KowalskiThomas commented Mar 12, 2026

Great, thank you! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KowalskiThomas @YvesDup @encukou @StanFromIreland